MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001701MPDpublic2008-06-17 13:192008-10-16 07:21
Reportermbz 
Assigned Toshank 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionduplicate 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001701: added support of ffmpeg/ape, wavpack and initial support of .cue sheets
DescriptionUnfortunately the latest mpd 0.13.2 doesn't support wv,ape and cue-sheets while almost all my music is in these formats. So I've tried to add this functionality.

The patch include:
ffmpeg/ape plugin,
wavpack plugin,
initial cue-sheet support (someone should fix the stopping of decoding)

(The patch is against 0.13.2).
Additional InformationThis patch is intended for developers who want to continue my work...
TagsNo tags attached.
Attached Filesbz2 file icon cue_ape_wv.patch.bz2 [^] (11,260 bytes) 2008-06-17 13:19
patch file icon cue_trackdelete_fix.patch [^] (544 bytes) 2008-08-22 19:36 [Show Content]
patch file icon mpd_cue_stop_decoding_fix.patch [^] (2,245 bytes) 2008-08-30 10:53 [Show Content]

- Relationships
duplicate of 0001369closedcirrus [FLAC cue sheets] .cue support 
has duplicate 0001730closedcirrus cue reminder for cirrus 
related to 0001666closedshank wma Support 

-  Notes
(0001969)
worklez (reporter)
2008-06-20 07:50

Why not to use source from/link to cuetools for parsing cuesheets?

/* I was going to do this work too. You ahead. :) */
(0001970)
scant (reporter)
2008-06-22 14:47

Can someone please finish the CUE sheet part of this patch (utilizing cuetools)?
(0001990)
b3nd3r (reporter)
2008-07-27 23:04

Patch is working? When I compile my mpd 0.13.2 I have some error messages

mpd-directory.o: In function `addCueToDirectory':
/home/b3nd3r/Downloads/mpd-0.13.2/src/directory.c:824: undefined reference to `cue_parse_from_file'
/home/b3nd3r/Downloads/mpd-0.13.2/src/directory.c:871: undefined reference to `cue_free_tracks'
mpd-inputPlugin.o: In function `initInputPlugins':
/home/b3nd3r/Downloads/mpd-0.13.2/src/inputPlugin.c:153: undefined reference to `ffmpegPlugin'
/home/b3nd3r/Downloads/mpd-0.13.2/src/inputPlugin.c:154: undefined reference to `wvPlugin'
(0001995)
mbz (reporter)
2008-08-04 22:07

b3nd3r, you should do autoreconf since I didn't attach modifications for the configure/Makefile's
(0002000)
deeg (reporter)
2008-08-08 06:56
edited on: 2008-08-16 08:17

I do:

patch -p1 < cue_ape_wv.patch
autoreconf
./configure
make

:and got error:

[ mpd-0.13.2 ] $ make
cd . && /bin/sh /home/myname/DOWNLOADS/mpd/mpd-0.13.2/missing --run autoheader
rm -f stamp-h1
touch config.h.in
cd . && /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
make all-recursive
make[1]: Entering directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2'
Making all in src
make[2]: Entering directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2/src'
Making all in mp4ff
make[3]: Entering directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2/src/mp4ff'
/bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -DUSE_TAGGING=1 -g -O2 -MT mp4ff.lo -MD -MP -MF .deps/mp4ff.Tpo -c -o mp4ff.lo mp4ff.c
../../libtool: line 790: X--tag=CC: command not found
../../libtool: line 823: libtool: ignoring unknown tag : command not found
../../libtool: line 790: X--mode=compile: command not found
../../libtool: line 956: *** Warning: inferring the mode of operation is deprecated.: command not found
../../libtool: line 957: *** Future versions of Libtool will require --mode=MODE be specified.: command not found
../../libtool: line 1100: Xgcc: command not found
../../libtool: line 1100: X-DHAVE_CONFIG_H: command not found
../../libtool: line 1100: X-I.: command not found
../../libtool: line 1100: X-I../..: No such file or directory
../../libtool: line 1100: X-DUSE_TAGGING=1: command not found
../../libtool: line 1100: X-g: command not found
../../libtool: line 1100: X-O2: command not found
../../libtool: line 1100: X-MT: command not found
../../libtool: line 1100: Xmp4ff.lo: command not found
../../libtool: line 1100: X-MD: command not found
../../libtool: line 1100: X-MP: command not found
../../libtool: line 1100: X-MF: command not found
../../libtool: line 1100: X.deps/mp4ff.Tpo: No such file or directory
../../libtool: line 1100: X-c: command not found
../../libtool: line 1151: Xmp4ff.lo: command not found
../../libtool: line 1156: libtool: compile: cannot determine name of library object from `': command not found
make[3]: *** [mp4ff.lo] Error 1
make[3]: Leaving directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2/src/mp4ff'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/myname/DOWNLOADS/mpd/mpd-0.13.2'
make: *** [all] Error 2
[ mpd-0.13.2 ] $

sorry for my long post and please help.

(0002005)
DsTr (reporter)
2008-08-15 17:57
edited on: 2008-08-15 17:58

deeg
In archlinux I have install libtool 2.2.4 and do "cp /usr/bin/libtool ." in the dir with sources...



This patch supports cue+flac in collection?

(0002006)
deeg (reporter)
2008-08-16 08:13
edited on: 2008-08-16 08:16

Thank you, DsTr!

In Archlinux, do:

patch -p1 < cue_ape_wv.patch
sed -i 's|ffmpeg/avcodec.h|libavcodec/avcodec.h|' src/inputPlugins/ffmpeg_plugin.c
sed -i 's|ffmpeg/avformat.h|libavformat/avformat.h|' src/inputPlugins/ffmpeg_plugin.c
autoreconf
./configure
cp /usr/bin/libtool .
make
......

(0002007)
DsTr (reporter)
2008-08-16 20:11

I post PKGBULD with patch to aur
http://aur.archlinux.org/packages.php?ID=19147 [^]


Thanks for patch! It`s great!
(0002010)
DsTr (reporter)
2008-08-17 20:37
edited on: 2008-08-22 19:37

When rescanning library - MPD removing CUE+* from db, since mpd cannot find "file?startms..." in the directory

This is small fix in attach: cue_trackdelete_fix.patch

(0002029)
DsTr (reporter)
2008-08-30 10:55
edited on: 2008-08-30 11:15

There is fix the stopping of decoding: mpd_cue_stop_decoding_fix.patch

Now the patch is usable...

In sources dir:
patch -p1 < cue_ape_wv.patch
sed -i 's|ffmpeg/avcodec.h|libavcodec/avcodec.h|' src/inputPlugins ffmpeg_plugin.c
sed -i 's|ffmpeg/avformat.h|libavformat/avformat.h|' src/inputPlugins/ffmpeg_plugin.c
patch -p0 < cue_trackdelete_fix.patch
patch -p1 < mpd_cue_stop_decoding_fix.patch
autoreconf
./configure --prefix=/usr
cp /usr/bin/libtool .
make


- Issue History
Date Modified Username Field Change
2008-06-17 13:19 mbz New Issue
2008-06-17 13:19 mbz Status new => assigned
2008-06-17 13:19 mbz Assigned To => shank
2008-06-17 13:19 mbz File Added: cue_ape_wv.patch.bz2
2008-06-20 07:50 worklez Note Added: 0001969
2008-06-22 14:47 scant Note Added: 0001970
2008-07-27 23:04 b3nd3r Note Added: 0001990
2008-08-04 22:07 mbz Note Added: 0001995
2008-08-08 06:56 deeg Note Added: 0002000
2008-08-15 17:57 DsTr Note Added: 0002005
2008-08-15 17:58 DsTr Note Edited: 0002005
2008-08-16 08:13 deeg Note Added: 0002006
2008-08-16 08:16 deeg Note Edited: 0002006
2008-08-16 08:17 deeg Note Edited: 0002000
2008-08-16 20:11 DsTr Note Added: 0002007
2008-08-17 20:37 DsTr Note Added: 0002010
2008-08-22 19:36 DsTr File Added: cue_trackdelete_fix.patch
2008-08-22 19:37 DsTr Note Edited: 0002010
2008-08-30 10:53 DsTr File Added: mpd_cue_stop_decoding_fix.patch
2008-08-30 10:55 DsTr Note Added: 0002029
2008-08-30 10:56 DsTr Note Edited: 0002029
2008-08-30 11:06 DsTr Note Edited: 0002029
2008-08-30 11:15 DsTr Note Edited: 0002029
2008-09-10 16:02 zaunmayrchris Relationship added related to 0001666
2008-10-14 16:25 cirrus Relationship added has duplicate 0001730
2008-10-16 07:21 cirrus Relationship added duplicate of 0001369
2008-10-16 07:21 cirrus Status assigned => closed
2008-10-16 07:21 cirrus Resolution open => duplicate


Copyright © 2000 - 2014 MantisBT Team
Powered by Mantis Bugtracker